Re: splitting plpython into smaller parts
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Greg Smith <greg@2ndQuadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-11-29T05:02:21Z
Lists: pgsql-hackers
On mån, 2011-11-28 at 02:00 -0800, Greg Smith wrote: > On 11/13/2011 09:45 AM, Jan Urbański wrote: > > The first one factors out some bolerplate related to executing SPI > > functions in subtransactions (and idea borrowed from pltcl.c). > > While I haven't looked at the code, this seems worthwhile from the > description. > > > The second one is the actual split. plpython.c has been split into 11 > > separate files and one header. > > Could you comment a bit more about what the goal of this is? We don't > have a reviewer for this patch yet, and I think part of the reason is > because it's not really obvious what it's supposed to be doing, and why > that's useful. I will look into it.