Re: pg_upgrade relation OID mismatches

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Peter Eisentraut <peter_e@gmx.net>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2011-11-25T20:26:24Z

Lists: pgsql-hackers

Excerpts from Bruce Momjian's message of vie nov 25 17:05:09 -0300 2011:

> OK, it turns out that exclusion contraints used in pre-9.2 regression
> tests were deleted before the regression tests finished, which means
> they were not tested by me.  (This might be a good reason _not_ to have
> the regression tests removing objects before the scripts exit.)

Yeah, I vote for most/all tests keeping their objects instead of
dropping them, where sensible.  Also, some tests use a single table name
and create it and drop it just to create it again later with different
properties (I think the alter_table test is like this).  We should
avoid that.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support