btvacuumpage useless "orig_blkno"
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Date: 2011-11-21T22:03:59Z
Lists: pgsql-hackers
Attachments
- btvacuumscan.patch (application/octet-stream) patch
I just noticed that btvacuumpage has two BlockNumber parameters -- blkno and orig_blkno. The only caller passes them as the same value; the header comments state that blkno would be different when recursing, but actually the function implements recursion internally by way of a cute "goto" trick. So it seems to me that the orig_blkno parameter is useless -- we could just remove it. Unless I'm completely missing something? -- Álvaro Herrera <alvherre@alvh.no-ip.org>