Re: Adding Node support in outfuncs.c and readfuncs.c
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
Cc: pgsql-hackers@postgresql.org
Date: 2011-11-16T18:38:46Z
Lists: pgsql-hackers
On ons, 2011-11-09 at 20:14 +0100, Dimitri Fontaine wrote: > The task in $subject is something I will have to do repeatedly for > completing the Command Trigger patch. I've been doing some of them > manually, covering initdb. Then I've been scripting away the editing. > > The script takes a Node number as input (because that's what you're > given in ERROR messages) and as an output will edit outfuncs.c and > readfuncs.c for you. > > That's only intended as a developer friendly help, not a part of the > build process or the like, and I've been writing that in Emacs Lisp -- > that's what make most sense to me (I don't do perl). Now, I intend to > be > maintaining the script if needs be, and it could be useful for others > too. > > What about adding that into src/tools/editors/pgsrc.el? This is a massive amount of code that very few people in our community will use, and very few be able to maintain it, too. If you want to make a lasting contribution on this area, write a program that generates the node handling functionality automatically as part of the build process.