Re: BUG #15511: Drop table error "invalid argument"
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: ertugrul9090@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-02-05T11:28:44Z
Lists: pgsql-bugs
On 07/12/2018 00:38, Tom Lane wrote: > ... so my preliminary result is that there's a *boatload* of "invalid" > format strings in our translation files, all of them apparently with > the extra-space disease. See attached. A bit of follow-up: I have committed fixes for all the erroneous uses of space "flags" in translated format strings. These will then be in the next minor releases. I also looked into the gettext/msgfmt source code. We know that it does check for format string compatibility, but I found that it only checks the general type, not the formatting flags. I suppose this is not unreasonable, since a translation might want to space or align something differently. So we still don't have an easy way to check for this in the future. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Improve our response to invalid format strings, and detect more cases.
- d8e1de899c8e 11.2 landed
- d398119c19ef 9.6.12 landed
- d2b0b60e7193 12.0 landed
- a40ee75c1e2c 9.5.16 landed
- 6dc46f8ca83d 10.7 landed
- 3a691f8a25a8 9.4.21 landed