Re: pg_upgrade - add config directory setting

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: Peter Eisentraut <peter_e@gmx.net>, Steve Crawford <scrawford@pinpointresearch.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2011-09-29T13:44:29Z

Lists: pgsql-hackers

Excerpts from Bruce Momjian's message of jue sep 29 09:56:09 -0300 2011:
> 
> Thinking some more, I don't need to know the data directory while the
> server is down --- I already am starting it. pg_upgrade starts both old
> and new servers during its check phase, and it could look up the
> data_directory GUC variable and use that value when accessing files. 
> That would work for old and new servers.  However, I assume that is
> something we would not backpatch to 9.1.  

Why not?  We've supported separate data/config dirs for a long time now,
so it seems to me that pg_upgrade not coping with them is a bug.  If
pg_upgrade starts postmaster, it seems simple to grab the data_directory
setting, is it not?

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support