Re: pg_upgrade automatic testing
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-09-05T20:42:15Z
Lists: pgsql-hackers
On lör, 2011-09-03 at 19:58 -0400, Tom Lane wrote: > Anyway, after giving up on that I went back to plan A, namely install > regress.so and friends into $libdir. That turns out to be really quite > straightforward, though I had to hack pg_regress.c a bit to get its idea > of $libdir to match up exactly with the way the backend sees it. > (The only reason this matters is that there's one error report in the > regression tests where the full expansion of $libdir is reported. > Maybe we should just drop that one test case instead of maintaining > the infrastructure for replacing @libdir@ in pg_regress.c.) > > Attached is a draft patch for HEAD. It passes "make check" and "make > installcheck" on Unix, but I've not touched the MSVC scripts. > Comments? I'll try to integrate this with my pg_upgrade test runner to see if it gets the job done.