Allow pg_read_all_stats to read pg_stat_progress_*
x4mmm@yandex-team.ru
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2020-04-15T07:13:57Z
Lists: pgsql-hackers
Attachments
- allow_read_all_stats.diff (application/octet-stream) patch
Hi! One of our users asked me why they cannot read details of pg_stat_progress_vacuum while they have pg_read_all_stats role. Maybe I'm missing something, but I think they should be able to read stats... PFA fix. This affects pg_stat_progress_analyze, pg_stat_progress_basebackup, pg_stat_progress_cluster, pg_stat_progress_create_index and pg_stat_progress_vacuum. With patch postgres=# set role pg_read_all_stats ; postgres=> select * from pg_stat_progress_vacuum ; pid | datid | datname | relid | phase | heap_blks_total | heap_blks_scanned | heap_blks_vacuumed | index_vacuum_count | max_dead_tuples | num_dead_tuples -------+-------+----------+-------+---------------+-----------------+-------------------+--------------------+--------------------+-----------------+----------------- 76331 | 12923 | postgres | 1247 | scanning heap | 10 | 1 | 0 | 0 | 2910 | 0 (1 row) Without patch postgres=# set role pg_read_all_stats ; SET postgres=> select * from pg_stat_progress_vacuum ; pid | datid | datname | relid | phase | heap_blks_total | heap_blks_scanned | heap_blks_vacuumed | index_vacuum_count | max_dead_tuples | num_dead_tuples -------+-------+----------+-------+-------+-----------------+-------------------+--------------------+--------------------+-----------------+----------------- 76331 | 12923 | postgres | | | | | | | | (1 row) Thanks! Best regards, Andrey Borodin.
Commits
-
Allow pg_read_all_stats to access all stats views again
- d0bb66572e33 10.13 landed
- 3d4652f67d1f 11.8 landed
- 212e712a5eed 12.3 landed
- 7e4e574744c1 13.0 landed