Horton

Re: VACUUM can finish an interrupted nbtree page split -- is that okay?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-05-14T03:29:59Z
Lists: pgsql-hackers 
Peter Geoghegan <pg@bowt.ie> writes:
> To be fair, I suppose that the code made more sense when it first went
> in, because at the time there was a chance that there could be
> leftover half-dead internal pages. But, that was a long time ago now.

Is there a good reason to assume there are none left anywhere?

			regards, tom lane

Commits

  1. Remove extra nbtree half-dead internal page check.

  2. Note case where nbtree VACUUM finishes splits.

  3. Fix error when trying to delete page with half-dead left sibling.

  4. Fix race condition in B-tree page deletion.