Horton

Re: Declarative partitioning vs. sql_inheritance

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dmitry Ivanov <d.ivanov@postgrespro.ru>, Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>, Erik Rijkers <er@xs4all.nl>, Amit Langote <amitlangote09@gmail.com>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org
Date: 2016-12-16T16:26:00Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> An earlier version of Amit's patches tried to handle this by forcing
> sql_inheritance on for partitioned tables, but it wasn't
> well-implemented and I don't see the point anyway.  Sure, turning off
> sql_inheritance off for partitioned tables produces stupid results.
> But turning off sql_inheritance for inheritance hierarchies also
> produces stupid results.  If we were going to do anything about this,
> my vote would be to remove sql_inheritance.

+1.  If memory serves, we invented that GUC as a backwards-compatibility
hack, because once upon a time the default behavior was equivalent to
sql_inheritance = off.  But that was a long time ago; a bit of digging
in the git history suggests we changed it in 2000.  It's hard to believe
that anybody still relies on being able to turn it off.

			regards, tom lane

Commits

  1. Replace enum InhOption with simple boolean.

  2. Remove sql_inheritance GUC.