Re: warning: comparison of integer expressions of different signedness related to simd.h
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-03T05:57:32Z
Lists: pgsql-hackers
John Naylor <john.naylor@enterprisedb.com> writes: > On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com> wrote: >> /usr/local/pgsql/master/include/server/port/simd.h: In function ‘vector8_has’: >> /usr/local/pgsql/master/include/server/port/simd.h:168:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare] >> 168 | for (int i = 0; i < sizeof(Vector8); i++) > "int" should probably be "Size" -- does that remove the warning? Agreed, should be Size or size_t, or else cast the sizeof() result. But I wonder why none of the buildfarm is showing such a warning. regards, tom lane
Commits
-
Fix sign-compare warnings arising from port/simd.h
- 73b9d051c607 16.0 landed