Re: a modest improvement to get_object_address()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Robert Haas <robertmhaas@gmail.com>

Cc: pgsql-hackers@postgresql.org

Date: 2011-11-09T14:54:47Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Try to acquire relation locks in RangeVarGetRelid.
- 4240e429d0c2 9.2.0 cited

Robert Haas <robertmhaas@gmail.com> writes:
> I'd like to propose the attached patch, which changes
> get_object_address() in a manner similar to what we did in
> RangeVarGetRelid() in commit 4240e429d0c2d889d0cda23c618f94e12c13ade7.

I would think you need to drop the now-useless lock, and I sure hope
that RangeVarGetRelid does likewise.

			regards, tom lane