Horton
Menu

Re: 9.0beta2 - server crash when using HS + SR

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Fujii Masao <masao.fujii@gmail.com>, Greg Smith <greg@2ndquadrant.com>, Rafael Martinez <r.m.guerrero@usit.uio.no>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-06-30T17:27:27Z
Lists: pgsql-hackers 
Bruce Momjian <bruce@momjian.us> writes:
> The attached patch shows the hint only during recovery.

BTW, it would be easier and more consistent with the rest of the code to
look at InRecovery, instead of messing around with the function
signature.  And the usual way to emit a hint conditionally is

	(InRecovery ? errhint(...) : 0)

rather than duplicate a lot of surrounding code.

			regards, tom lane