Re: heap_hot_search_buffer refactoring
Jeff Davis <pgsql@j-davis.com>
From: Jeff Davis <pgsql@j-davis.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-06-19T18:01:10Z
Lists: pgsql-hackers
On Sun, 2011-06-19 at 10:50 -0700, Jeff Davis wrote:
> On Mon, 2011-06-06 at 14:03 -0400, Robert Haas wrote:
> > The attached patch refactors heap_hot_search_buffer() so that
> > index_getnext() can use it, and modifies index_getnext() to do so.
>
> Attached is a version of the patch that applies cleanly to master.
In heap_hot_search_buffer:
+ /* If this is not the first call, previous call returned
a (live!) tuple */
if (all_dead)
- *all_dead = true;
+ *all_dead = !first_call;
I think that's a typo: it should be:
+ *all_dead = first_call;
Right?
Regards,
Jeff Davis