Re: creating CHECK constraints as NOT VALID

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>

To: Simon Riggs <simon@2ndquadrant.com>

Cc: Thom Brown <thom@linux.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2011-06-04T18:21:39Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix pg_get_constraintdef to cope with NOT VALID constraints
- 048417511aef 9.1.0 cited

Excerpts from Simon Riggs's message of sáb jun 04 09:11:52 -0400 2011:
> On Thu, Jun 2, 2011 at 5:48 PM, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:

> > Actually, it turns out that NOT VALID foreign keys were already buggy
> > here, and fixing them automatically fixes this case as well, because the
> > fix involves touching pg_get_constraintdef to dump the flag.  This also
> > gets it into psql's \d.  Patch attached.
> >
> > (Maybe the changes in psql's describe.c should be reverted, not sure.)
> 
> Thanks. As soon as Thom said that, I thought "ahh... didn't do that".
> 
> Patch looks fine. Will you commit this patch to 9.1 now, or would you
> like me to?

Thanks for the review.  I already committed it on 9.1:
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=048417511aef8d5fb2d541b17b73afc730935cd5

I'd still like your opinion on the psql bits.  Should they be reverted?
I haven't verified what the output currently looks like.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support