Horton

Re: creating CHECK constraints as NOT VALID

Alvaro Herrera <alvherre@commandprompt.com>

View thread
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Thom Brown <thom@linux.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2011-06-02T16:48:42Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix pg_get_constraintdef to cope with NOT VALID constraints

Attachments

Excerpts from Alvaro Herrera's message of mié jun 01 20:56:12 -0400 2011:
> Excerpts from Thom Brown's message of mié jun 01 19:48:44 -0400 2011:
> 
> > Is this expected?
> > [ pg_dump fails to preserve not-valid status of constraints ]
> 
> Certainly not.
> 
> > Shouldn't the constraint be dumped as not valid too??
> 
> Sure, I'll implement that tomorrow.

Actually, it turns out that NOT VALID foreign keys were already buggy
here, and fixing them automatically fixes this case as well, because the
fix involves touching pg_get_constraintdef to dump the flag.  This also
gets it into psql's \d.  Patch attached.

(Maybe the changes in psql's describe.c should be reverted, not sure.)

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support