Re: unite recovery.conf and postgresql.conf

Josh Berkus <josh@agliodbs.com>

From: Joshua Berkus <josh@agliodbs.com>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tatsuo Ishii <ishii@postgresql.org>, pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>

Date: 2011-09-25T20:13:20Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Restructure error handling in reading of postgresql.conf.
- d56b3afc0376 9.2.0 cited


> I rather like Tom's suggestion of include_if_exists.

include_if_exists certainly solves the recovery.conf/recovery.done problem.  We can even phase it out, like this:

9.2: include_if_exists = 'recovery.conf' in the default postgresql.conf file.
9.3: include_if_exists = 'recovery.conf' commented out by default
9.4: renaming recovery.conf to recovery.done by core PG code removed.

This gives users/vendors 3 years to update their scripts to remove dependence on recovery.conf.  I'm afraid that I agree with Simon that there's already a whole buncha 3rd-party code out there to support the current system.

--Josh Berkus