Re: inconvenient compression options in pg_basebackup
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-05-24T18:40:35Z
Lists: pgsql-hackers
Attachments
- pg_basebackup-compress.patch (text/x-patch) patch
On sön, 2011-05-22 at 16:43 -0400, Magnus Hagander wrote: > On Fri, May 20, 2011 at 17:45, Peter Eisentraut <peter_e@gmx.net> wrote: > > On fre, 2011-05-20 at 14:19 -0400, Magnus Hagander wrote: > >> > I suggest we add an argument-less option -z that means "compress", > >> and > >> > then -Z can be relegated to choosing the compression level. > >> > >> We can't just use -Z without a parameter for that? > > > > You can't portably have a command-line option with an optional argument. > > Ugh. > > In that case, I'm fine with your suggestion. Quick patch for verification. I chose the naming -z/--gzip to mirror GNU tar.