Re: Radix tree for character conversion
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
hlinnaka <hlinnaka@iki.fi>,
"Tsunakawa,
Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
Tatsuo Ishii <ishii@sraoss.co.jp>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-10-28T13:42:25Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Thu, Oct 27, 2016 at 3:23 AM, Kyotaro HORIGUCHI > <horiguchi.kyotaro@lab.ntt.co.jp> wrote: >> Perhaps we can put the files into our repositoy by providing some >> notifications. > Uggh, I don't much like advertising clauses. Even if the license were exactly compatible with ours, I'd be -1 on bloating our tarballs with these files. They're large and only a tiny fraction of developers, let alone end users, will ever care to look at them. I think it's fine as long as we have a README file that explains where to get them. (I'm not even very thrilled with the proposed auto-download script, as it makes undesirable assumptions about which internet tools you use, not to mention that it won't work at all on Windows.) I'd actually vote for getting rid of the reference files we have in the tree now (src/backend/utils/mb/Unicode/*txt), on the same grounds. That's 600K of stuff that does not need to be in our tarballs. regards, tom lane
Commits
-
Use radix tree for character encoding conversions.
- aeed17d00037 10.0 landed
-
Small fixes to the Perl scripts to create unicode conversion tables.
- bc1686f3f653 10.0 landed
-
Rewrite the perl scripts to produce our Unicode conversion tables.
- 1de9cc0dcca6 10.0 landed
-
Remove leading zeros, for consistency with other map files.
- 6c303223be34 10.0 landed
-
Remove code points < 0x80 from character conversion tables.
- 2c09c93ce1b8 10.0 landed