Horton

Re: windows consolidated cleanup

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-04-24T14:57:59Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move include for Python.h above postgres.h to eliminate compiler warning.

The hunk below looks a bit evil.

At least a comment would be good to explain why this is necessary.

On sön, 2011-04-24 at 01:29 -0400, Andrew Dunstan wrote:
> *** a/src/backend/port/win32/socket.c
> --- b/src/backend/port/win32/socket.c
> ***************
> *** 370,376 **** pgwin32_recv(SOCKET s, char *buf, int len, int f)
>   }
>   
>   int
> ! pgwin32_send(SOCKET s, char *buf, int len, int flags)
>   {
>         WSABUF          wbuf;
>         int                     r;
> --- 370,376 ----
>   }
>   
>   int
> ! pgwin32_send(SOCKET s, const char *buf, int len, int flags)
>   {
>         WSABUF          wbuf;
>         int                     r;
> ***************
> *** 380,386 **** pgwin32_send(SOCKET s, char *buf, int len, int flags)
>                 return -1;
>   
>         wbuf.len = len;
> !       wbuf.buf = buf;
>   
>         /*
>          * Readiness of socket to send data to UDP socket may be not true: socket
> --- 380,386 ----
>                 return -1;
>   
>         wbuf.len = len;
> !       wbuf.buf = (char *) buf;
>   
>         /*
>          * Readiness of socket to send data to UDP socket may be not true: socket
> 
>