Horton

Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-12-14T20:09:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove troublesome Asserts in cost_mergejoin().

  2. Enable building with the Mingw64 compiler.

Andrew Dunstan <andrew@dunslane.net> writes:
>     +  # Disable FP optimizations that cause isinf errors on gcc 4.5+
>     +  PGAC_PROG_CC_CFLAGS_OPT([-fexcess-precision=standard])

Looks sane to me, except "isinf errors" is an awfully narrow reading of
the problem.  Maybe just say "assorted errors"?  Also, do we know that
gcc 4.5 poses the issue?  I'm only aware of reports for 4.6 and 4.7.

> I guess we should backpatch it?

+1.  Back branches will see these same problems as soon as anybody
tries to compile them with latest-n-greatest gcc.

			regards, tom lane