Horton
Menu

Re: assertion failure w/extended query protocol

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org, Peter Geoghegan <peter@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>
Date: 2012-10-19T22:37:54Z
Lists: pgsql-hackers 
Andres Freund <andres@2ndquadrant.com> writes:
> So as far as I can see the new logic is correct? A quick look & test seems to
> confirm that.

I think the real problem here is just that the code was trying to be too
specific, and while your version might be more correct it's not doing
anything to fix that misjudgment.  We should just make the
CreateTableAsStmt case look like the ExplainStmt case, viz

            Assert(IsA(qry, Query));
            if (qry->commandType == CMD_UTILITY)
                return UtilityContainsQuery(qry->utilityStmt);
            return qry;

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Restructure SELECT INTO's parsetree representation into CreateTableAsStmt.