Horton

Re: Typed-tables patch broke pg_upgrade

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>, pgsql-hackers@postgreSQL.org
Date: 2011-03-30T16:50:12Z
Lists: pgsql-hackers

Attachments

On tor, 2011-02-10 at 06:31 +0200, Peter Eisentraut wrote:
> > ERROR:  cannot drop column from typed table
> > 
> > which probably is because test_type2 has a dropped column.
> 
> It should call
> 
> ALTER TYPE test_type2 DROP ATTRIBUTE xyz CASCADE;
> 
> instead.  That will propagate to the table.

Here is a patch that addresses this problem.

It looks like Noah Misch might have found another problem in this area.
We'll have to investigate that.