Re: Another swing at JSON
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: Joseph Adams <joeyadams3.14159@gmail.com>,
David Fetter <david@fetter.org>, Robert Haas <robertmhaas@gmail.com>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-03-30T13:27:39Z
Lists: pgsql-hackers
Excerpts from Dimitri Fontaine's message of mié mar 30 05:27:07 -0300 2011: > Alvaro Herrera <alvherre@commandprompt.com> writes: > > Why are you worrying with the non-PGXS build chain anyway? Just assume > > that the module is going to be built with PGXS and things should just > > work. > > > > We've gone over this a dozen times in the past. > > +1 > > I'm not sure why we still support the pre-PGXS build recipe in the > contrib Makefiles, and didn't want to change that as part as the > extension patch series, but I think we should reconsider. This is in the archives somewhere. I think it's something to do with the fact that "make check" doesn't work under PGXS; you have to use "make installcheck". Or maybe it was something else. I don't really remember the details. I also pushed for this, a long time ago. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support