Horton

Re: Macros for time magic values

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2011-03-14T08:22:59Z
Lists: pgsql-hackers 
On Sat, 2011-03-12 at 22:29 +0200, Peter Eisentraut wrote:
> On fre, 2011-03-11 at 12:50 -0500, Bruce Momjian wrote:
> > It has bothered me that many of our time routines use special magic
> > constants for time values, e.g. 24, 12, 60, etc.
> > 
> > The attached patch changes these magic constants to macros to clarify
> > the code.  I would like to apply this for 9.1 as a cleanup.
> 
> I think it's much clearer with the plain numbers.

Yeh. It's not like the values 24, 12 or 60 were going to change.

-- 
 Simon Riggs           http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services