Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nino Floris <mail@ninofloris.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
Michael Paquier <michael@paquier.xyz>,
Alvaro Herrera <alvherre@2ndquadrant.com>,
Alexander Korotkov <a.korotkov@postgrespro.ru>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-04-01T21:37:15Z
Lists: pgsql-hackers
I wrote: > Fortunately for the odds of getting this patch accepted, we just > pushed an ALTER TYPE improvement that will solve your problem [1]. > Please replace ltree--1.2.sql with an upgrade script that uses > that, and resubmit. I decided it would be a shame for this to miss v13, seeing that (a) it'd provide real-world use of that ALTER TYPE code, and (b) we already bumped ltree's extension version for v13. So I went ahead and rebased this, reviewed and pushed it. The main non-cosmetic thing I changed, other than using ALTER TYPE, was that you had the output functions looking like this: pq_sendtext(&buf, res, pg_mbstrlen(res)); That's just wrong; it should be plain strlen(). Did you copy that coding from someplace? I could not find any similar occurrences in our code tree. regards, tom lane
Commits
-
Add support for binary I/O of ltree, lquery, and ltxtquery types.
- 949a9f043eb7 13.0 landed
-
Allow ALTER TYPE to change some properties of a base type.
- fe30e7ebfa38 13.0 cited