Horton

Re: cpluspluscheck vs ICU again

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2025-08-06T14:01:03Z
Lists: pgsql-hackers 
John Naylor <johncnaylorls@gmail.com> writes:
> On Wed, Aug 6, 2025 at 12:26 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> BTW, I see that you applied ed26c4e25 only to master, but don't
>> we want to back-patch?  cpluspluscheck is not just an exercise in a
>> vacuum, it's to ensure that C++-coded extensions don't have trouble
>> with our headers.

> I was thinking that it was run only when developing new features, not
> for backpatch-able bug fixes, but that's a flawed assumption. I'll
> remedy that soon along with the new symbols above, unless you beat me
> to it.

Sounds good, thanks for dealing with it.

			regards, tom lane

Commits

  1. Update ICU C++ API symbols

  2. Hide ICU C++ APIs from pg_locale.h

  3. Remove implicit cast from 'void *'

  4. Inline CRC computation for small fixed-length input on x86