Re: CASE control block broken by a single line comment
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erik Wienhold <ewie@ewie.name>
Cc: Michal Bartak <maxym.srpl@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-04-13T05:45:35Z
Lists: pgsql-hackers
Erik Wienhold <ewie@ewie.name> writes: > On 2024-04-13 00:20 +0200, Tom Lane wrote: >> I'm not here to defend plpgsql's factorization ;-). However, it >> doesn't really have a parser of its own, at least not for expressions, >> so I'm not sure how your suggestion could be made to work. > Not a suggestion. Just a question about the general design, unrelated > to this fix, in case you know the answer off the cuff. I see that > 863a62064c already had the lexer handle those compound tokens, but > unfortunately without an explanation on why. Never mind if that's too > much to ask about a design descision made over 25 years ago. Well, it was a design decision I wasn't involved in, so I dunno. You could reach out to Jan on the slim chance he remembers. regards, tom lane
Commits
-
Fix plpgsql's handling of -- comments following expressions.
- f5cee411a190 13.15 landed
- dc5824a06e97 14.12 landed
- d85db0a8e95c 15.7 landed
- 5e9d8bed0094 12.19 landed
- 5392dd3d2ad5 17.0 landed
- 48f216dc634b 16.3 landed