Re: Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial

Garick Hamlin <ghamlin@isc.upenn.edu> writes:
> On Tue, Jan 05, 2010 at 02:02:51PM -0500, Tom Lane wrote:
>> I'm not nearly good enough in Perl to be sure about the semantics
>> of this loop.  Is it possible that it's changing the global contents
>> of the @$data structure, rather than just hacking a local copy of
>> each row before pushing some values into @fmgr?

> Yes, that is what would happen.  
> Is that a problem? (I haven't read the script)

Well, it *shouldn't* be a problem, but what it looks like to me is
that Stefan's perl version is somehow leaking one copy of the whole
$data structure each time through the loop.  If we were to copy and
then modify each row individually, maybe that'd dodge the bug.

			regards, tom lane