Re: What to do with inline warnings?

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gregory Stark <stark@enterprisedb.com>
Cc: "Martijn van Oosterhout" <kleptog@svana.org>, "Peter Eisentraut" <peter_e@gmx.net>, pgsql-hackers@postgresql.org
Date: 2008-05-14T19:48:36Z
Lists: pgsql-hackers
Gregory Stark <stark@enterprisedb.com> writes:
> Fwiw, these two call sites are only for when HeapTupleSatisfiesMVCC finds a
> tuples which has been moved away by VACUUM FULL... The latter for when it
> finds such a tuple but the VACUUM FULL aborted.

> It seems quite likely that the compiler is actually right (by chance) and we
> shouldn't be optimizing those cases at the expense of more common cases.

I trimmed the original message quite a bit --- there were a lot more
than two call sites that it was deciding not to inline.  Maybe it's
making the right choices or maybe not.

			regards, tom lane