PG versus libxml2 2.12.x
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Date: 2024-01-27T19:04:22Z
Lists: pgsql-hackers
Attachments
- v1-cope-with-libxml2-API-changes.patch (text/x-diff) patch v1
Buildfarm member caiman has been failing build for a couple weeks now. The reason turns out to be that recent libxml2 has decided to throw a "const" into the signature required for custom error handlers. (API compatibility? What's that?) I don't mind adopting the "const" --- it's a good idea in isolation. The trouble is in fixing our code to work with both old and new libxml2 versions. We could thrash around with a configure test or something, but I think the most expedient answer is just to insert some explicit casts, as shown in the attached. It's possible though that some compilers will throw a cast-away-const warning. I'm not seeing any, but ... Also, I'm seeing a deprecation warning in contrib/xml2/xpath.c for xmlLoadExtDtdDefaultValue = 1; I'm not sure why that's still there, given that we disabled external DTD access ages ago. I propose we just remove it. In short, I suggest the attached. regards, tom lane
Commits
-
Fix incompatibilities with libxml2 >= 2.12.0.
- 400928b83bd2 17.0 landed
- b2fd1dab9024 12.18 landed
- 7c53b1977ba6 13.14 landed
- 29e25a6b1eb1 14.11 landed
- e02fea093ebb 16.2 landed
- 3f8ac13b1976 15.6 landed