Horton
Menu

Re: pg_stat_statements: calls under-estimation propagation

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Peter Geoghegan <pg@heroku.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Sameer Thakur <samthakur74@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2013-12-08T15:45:03Z
Lists: pgsql-hackers 
On Sat, 2013-12-07 at 16:00 -0800, Peter Geoghegan wrote:
> On Sat, Dec 7, 2013 at 3:50 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > 32-bit buildfarm members are having problems with this patch.
> 
> This should fix that problem. Thanks.

This is incidentally the same problem that was reported here about
another pg_stat_statements patch:
http://www.postgresql.org/message-id/BF2827DCCE55594C8D7A8F7FFD3AB7713DDAC54F@SZXEML508-MBX.china.huawei.com

Can we make this more robust so that we don't accidentally keep breaking
32-bit systems?  Maybe a static assert?

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve management of "sticky" entries in contrib/pg_stat_statements.