Re: Materialized views WIP patch
Kevin Grittner <kgrittn@ymail.com>
From: Kevin Grittner <kgrittn@ymail.com>
To: Noah Misch <noah@leadboat.com>,
Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2013-08-18T21:28:35Z
Lists: pgsql-hackers
Kevin Grittner <kgrittn@ymail.com> wrote: > Noah Misch <noah@leadboat.com> wrote: >> Also, could you explain the use of RelationCacheInvalidateEntry() >> in ExecRefreshMatView()? CacheInvalidateRelcacheByRelid() >> followed by CommandCounterIncrement() is the typical pattern; >> this is novel. I suspect, though, neither is necessary now that >> the relcache does not maintain populated status based on a fork >> size reading. > > Yeah, that was part of the attempt to support unlogged materialized > views while also not returning bogus results if the view had not > been populated, using heap file size. I agree that this line can > just come out. If there are no objections real soon now, I will > remove it in master and the 9.3 branch before the release > candidate. Done. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company