Re: pg_filedump 9.3: checksums (and a few other fixes)

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Satoshi Nagayasu <snaga@uptime.jp>
Cc: Josh Kupershmidt <schmiddy@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2013-07-06T05:43:33Z
Lists: pgsql-hackers
On Sat, 2013-07-06 at 10:30 +0900, Satoshi Nagayasu wrote:
> Hi,
> 
> It looks fine, but I have one question here.
> 
> When I run pg_filedump with -k against a database cluster which
> does not support checksums, pg_filedump produced checksum error as
> following. Is this expected or acceptable?

Thank you for taking a look. That is expected, because there is not a
good way to determine whether the file was created with checksums or
not. So, we rely on the user to supply (or not) the -k flag.

Regards,
	Jeff Davis




Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Refactor checksumming code to make it easier to use externally.