Horton
Menu

Re: pg_filedump 9.3: checksums (and a few other fixes)

Jeff Davis <pgsql@j-davis.com>

View thread
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2013-06-10T17:10:12Z
Lists: pgsql-hackers 
On Mon, 2013-06-10 at 11:38 -0400, Tom Lane wrote:
> The thing I'm not too happy about is having to copy the checksum code
> into pg_filedump.  We just got rid of the need to do that for the CRC
> code, and here it is coming back again.  Can't we rearrange the core
> checksum code similarly to what we did for the CRC stuff recently,
> so that you only need access to a .h file for it?

The CRC implementation is entirely in header files. Do you think we need
to go that far, or is it fine to just put it in libpgport and link that
to pg_filedump?

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Refactor checksumming code to make it easier to use externally.