Re: BUG #18995: Building with GCC 14 fails: incompatible pointer struct pam_message

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andrew Watkins <awatkins1966@gmail.com>

Cc: pgsql-bugs@lists.postgresql.org

Date: 2025-07-23T19:47:06Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix build breakage on Solaris-alikes with late-model GCC.
- e6dfd068ed45 19 (unreleased) landed
- e4d585455509 16.10 landed
- b252ce31116f 15.14 landed
- 868b39a544ed 14.19 landed
- 635a856279ef 17.6 landed
- 3d039b53a133 18.0 landed
- 1ccb3851db5d 13.22 landed

I wrote:
> I still see a way to avoid a configure check though: let's make
> src/include/port/solaris.h "#define _PAM_LEGACY_NONCONST".
> That should make OpenIndiana enough like other Solaris-alikes
> for the purpose, and we can also use that same symbol to cue
> our code how to declare the callback function.

Done that way at

https://git.postgresql.org/gitweb/?p=postgresql.git;a=patch;h=635a856279ef55074dfc7a2a96c7fd686b5ff015

If you can confirm that you get a clean build with this patch,
I'd appreciate it.

			regards, tom lane