Re: Assertion failure on UNLOGGED VIEW and SEQUENCE
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-18T19:39:17Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Fri, Feb 18, 2011 at 2:17 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> +1 for where you put the tests, but I don't think >> ERRCODE_SYNTAX_ERROR is an appropriate errcode. I'd go with >> FEATURE_NOT_SUPPORTED for both, I think. > I hesitate to use FEATURE_NOT_SUPPORTED for something that's > nonsensical anyway. I picked SYNTAX_ERROR after some scrutiny of what > I believe to be parallel cases, such as EXPLAIN (FOO) SELECT 1 and > CREATE TABLE t AS SELECT 1 INTO me. [ shrug... ] I don't care enough to argue about it. regards, tom lane