Re: SP-GiST for ranges based on 2d-mapping and quad-tree

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Alexander Korotkov <aekorotkov@gmail.com>

Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2012-10-21T07:22:54Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Teach SP-GiST to do index-only scans.
- 922036249340 9.2.0 cited

On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql@j-davis.com>
> wrote:
>         I am taking a look at this patch now. A few quick comments:
>         
>         * It looks like bounds_adjacent modifies it's by-reference
>         arguments,
>         which is a little worrying to me. The lower/upper labels are
>         flipped
>         back, but the inclusivities are not. Maybe just pass by value
>         instead?
>         
>         * Bounds_adjacent is sensitive to the argument order. Can't it
>         just take
>         bound1 and bound2?
> 
> 
> Fixed. Patch is attached.
> 
It looks like this is basically the same diff as v0.1. Did something get
mixed up?

Regards,
	Jeff Davis