Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, andrewbille@gmail.com,
pgsql-bugs@lists.postgresql.org
Date: 2025-10-16T01:47:52Z
Lists: pgsql-bugs
David Rowley <dgrowleyml@gmail.com> writes: > On Thu, 16 Oct 2025 at 14:31, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I'm confused by all the extraneous changes in this? > It includes the query rewrite too in order to get rid of the > subqueries in the targetlist to pg_attribute. Ah, I've not reviewed that bit. > We could just do the conditional calling of > the pg_get_*def() functions, but performance would still be terrible > for ignore_system_indexes=on due to the Seq Scans, and slightly worse > overall. Got it. Definitely looks promising, but I'm too tired to review the whole change. regards, tom lane