Re: SLRU statistics

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2020-05-14T19:45:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix async.c to not register any SLRU stats counts in the postmaster.
- 7fd89f4d7a51 13.0 landed
Use proper GetDatum function in pg_stat_get_slru().
- 043e3e040160 13.0 landed
Initialize SLRU stats entries to zero.
- f3d23d83ef9a 13.0 landed
Remove pg_xact from pg_stat_reset_slru docs
- e685ca63ca4f 13.0 landed
Remove pg_xact entry from SLRU stats
- 2e08d314ed07 13.0 landed
Track SLRU page hits in SimpleLruReadPage_ReadOnly
- 2b88fdde30d8 13.0 landed
Fix typo in SLRU stats documentation
- 2c220ca46f3f 13.0 landed
Collect statistics about SLRU caches
- 28cac71bd368 13.0 landed
Simplify and rename some GUC variables, per various recent discussions:
- 48f7e6439568 8.3.0 cited

Robert Haas <robertmhaas@gmail.com> writes:
> I'm confused by why SLRU statistics are reported by messages sent to
> the stats collector rather than by just directly updating shared
> memory.

It would be better to consider that as an aspect of the WIP stats
collector redesign, rather than inventing a bespoke mechanism for
SLRU stats that's outside the stats collector (and, no doubt,
would have its own set of bugs).  We don't need to invent even more
pathways for this sort of data.

			regards, tom lane