Re: xmlconcat (was 9.0 release notes done)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Peter Eisentraut <peter_e@gmx.net>, Bruce Momjian <bruce@momjian.us>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-03-24T22:15:33Z

Lists: pgsql-hackers

Andrew Dunstan <andrew@dunslane.net> writes:
> Hmm. OK. Well here is a patch that tries to fix the xmlconcat error, 
> anyway. It seems to work, but maybe could stand a little tightening.

I liked your previous idea (rethink the whole mess in 9.1) better.

As far as the patch itself is concerned, the complete lack of error
checks seems scary, and I wonder whether the case sensitivity and
lack of whitespace tolerance in the string comparisons is OK.

			regards, tom lane