Horton
Menu

Re: embedded list v2

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <peter@2ndquadrant.com>
Date: 2012-09-14T23:20:52Z
Lists: pgsql-hackers 
Excerpts from Tom Lane's message of vie sep 14 17:48:35 -0300 2012:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Here's an updated version of both patches, as well as a third patch that
> > converts the cc_node list link in catcache.c into an slist.
> 
> There's a lot of stuff here that seems rather unfortunate and/or sloppy.
> 
> Does it even compile?  The 0002 patch refers to a typedef ilist_d_head
> that I don't see defined anywhere.  (It would be good to shorten that
> name by a couple of characters anyway, for tab-stop alignment reasons.)

Hm, I might have submitted the wrong 0002 file.  Sorry about that.  (The
correct file would have the right typedef names and a couple of bugfixes
but it'd be pretty similar to what you read.)

> [many useful comments]
>
> Not a full review, just some things that struck me in a quick scan...

Great stuff nonetheless, many thanks.  I will see about submitting an
improved version.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Provide some static-assertion functionality on all compilers.

  2. Add infrastructure for compile-time assertions about variable types.

  3. Remove 576 references of include files that were not needed.

  4. More include file adjustments.

  5. Allow each C include file to compile on its own by including any needed