Re: pg_upgrade's exec_prog() coding improvement

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Bruce Momjian <bruce@momjian.us>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Peter Eisentraut <peter_e@gmx.net>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2012-08-24T15:44:33Z

Lists: pgsql-hackers

Attachments

upgrade_execprog-2.patch (application/octet-stream) patch

Actually it seems better to just get rid of the extra varargs function
and just have a single exec_prog.  The extra NULL argument is not
troublesome enough, it seems.  Updated version attached.

Again, win32 testing would be welcome.  Sadly, buildfarm does not run
pg_upgrade's "make check".

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services