Re: external_pid_file not removed on postmaster exit

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-08-17T05:43:21Z
Lists: pgsql-hackers

Attachments

On Fri, 2012-07-27 at 08:09 +0300, Peter Eisentraut wrote:
> It seems strange that the external_pid_file is never removed.  There is
> even a C comment about it:
> 
> /* Should we remove the pid file on postmaster exit? */
> 
> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.
> 
> Does anyone remember why this was not done originally or have any
> concerns?

Since that was not the case, I propose the attached patch to unlink the
external pid file.