Horton

Re: Rearranging ALTER TABLE to avoid multi-operations bugs

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-15T18:12:56Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I didn't review in detail, but it seems good to me.  I especially liked
> getting rid of the ProcessedConstraint code, and the additional test
> cases.

Thanks for looking!

Yeah, all those test cases expose situations where we misbehave
today :-(.  I wish this were small enough to be back-patchable,
but it's not feasible.

			regards, tom lane

Commits

  1. Clarify behavior of adding and altering a column in same ALTER command.

  2. Restructure ALTER TABLE execution to fix assorted bugs.

  3. doc: Add best practises section to partitioning docs

  4. Allow on-the-fly capture of DDL event details