Horton

Re: CREATE FOREGIN TABLE LACUNA

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: David Fetter <david@fetter.org>, Alvaro Herrera <alvherre@commandprompt.com>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-12T21:00:27Z
Lists: pgsql-hackers 
On lör, 2012-06-23 at 23:08 +0100, Dean Rasheed wrote:
> I spotted a couple of other issues during testing:
> 
> * You're still allowing INCLUDING DEFAULTS and INCLUDING STORAGE, even
> though these options are not supported on foreign tables.
> 
> * If I do INCLUDING ALL, I get an error because of the unsupported
> options. I think that "ALL" in this context needs to be made to mean
> all the options that foreign tables support (just COMMENTS at the
> moment).

Note that when I added CREATE TABLE LIKE to support composite types, it
was decided to ignore non-applicable options (like copying indexes from
types or views etc.).  The same should be done here, unless we have
reasons to revise the earlier decision.