Horton

Re: enhanced error fields

Alvaro Herrera <alvherre@commandprompt.com>

View thread
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Peter Geoghegan <peter@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-10T20:26:12Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Create a "sort support" interface API for faster sorting.

Excerpts from Peter Geoghegan's message of mar jul 10 15:54:59 -0400 2012:
> On 10 July 2012 20:28, Alvaro Herrera <alvherre@commandprompt.com> wrote:

> > FWIW about the new include:  I feel a strong dislike about the forward
> > declaration you suggest.  Defining Relation in elog.h seems completely
> > out of place.  The one you suggested as precedent (BufFile) is
> > completely unlike it, in that the declaration is clearly placed in the
> > header (buffile.h) of the module that works with the struct in question.
> 
> I haven't defined Relation in elog.h; I have pre-declared it there.
> Maybe that isn't to your taste, but there is surely something to be
> said for adding exactly one line of code in preference to adding an
> entire new header file, and having a bunch of existing files include
> that new header.

That is true.  I'd like to hear others' opinions.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support