Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: alexey.shishkin@enterprisedb.com, pgsql-docs@lists.postgresql.org
Date: 2025-07-09T19:30:04Z
Lists: pgsql-docs
"David G. Johnston" <david.g.johnston@gmail.com> writes: > Its good as far a narrow fix goes. > But how about the attached? More invasive but covers the salient points > better, IMO, and less repetitive than having the two fields have their own > basically copy-pasted paragraphs. Meh... I initially thought that merging the two paras sounded like a good idea, but I'm not finding that this formulation reads any better. Notably, as things stand we have parallel constructions "If the <field> starts with an <x> character" in the preceding para as well as these two, and I think it's good to keep that parallelism. I do agree that it's overly repetitive, but we could improve that by dropping the second instance of the parenthetical link to posix-syntax-details. > I didn't add an example but felt the point "be referenced a single time > within" to be needed since, usefulness not withstanding, writing \1\1 for > database-username works but only the first instance of \1 is replaced. Hmm, I wonder if that isn't a bug we should fix. It's hard to believe anyone is relying on the second \1 *not* getting replaced, and perhaps there are use-cases for multiple replacements. > Also, should we attempt to align this documentation and > pg_ident.conf.sample as pertains to pg-username vs. database-username? Agreed that making pg_ident.conf.sample match would be an improvement. regards, tom lane
Commits
-
Doc: clarify description of regexp fields in pg_ident.conf.
- ff6783ce5260 16.10 landed
- f8ce5dea433c 18.0 landed
- dc70816fde6e 13.22 landed
- b70a2e8a1a0d 17.6 landed
- 6f7d016e917e 14.19 landed
- 5fe55a0fe40e 19 (unreleased) landed
- 2132ced7dc97 15.14 landed
-
In username-map substitution, cope with more than one \1.
- 3c4e26a62c31 19 (unreleased) landed