Thread

1. Re: foreign key locks

   Kevin Grittner <kevin.grittner@wicourts.gov> — 2012-06-23T22:38:10Z

   Alvaro Herrera  wrote:
    
   > So here's the rebased version.
    
   I found a couple problems on `make check-world`.  Attached is a patch
   to fix one of them.  The other is on pg_upgrade, pasted below.
    
   + pg_upgrade -d
   /home/kevin/pg/master/contrib/pg_upgrade/tmp_check/data.old -D
   /home/kevin/pg/master/contrib/pg_upgrade/tmp_check/data -b
   /home/kevin/pg/master/contrib/pg_upgrade/tmp_check/install//home/
   kevin/pg/master/Debug/bin -B
   /home/kevin/pg/master/contrib/pg_upgrade/tmp_check/install//home/
   kevin/pg/master/Debug/bin
   Performing Consistency Checks
   -----------------------------
   Checking current, bin, and data directories                 ok
   Checking cluster versions                                   ok
   Checking database user is a superuser                       ok
   Checking for prepared transactions                          ok
   Checking for reg* system OID user data types                ok
   Checking for contrib/isn with bigint-passing mismatch       ok
   Creating catalog dump                                       ok
   Checking for presence of required libraries                 ok
   Checking database user is a superuser                       ok
   Checking for prepared transactions                          ok
   
   If pg_upgrade fails after this point, you must re-initdb the
   new cluster before continuing.
   
   Performing Upgrade
   ------------------
   Analyzing all rows in the new cluster                       ok
   Freezing all rows on the new cluster                        ok
   Deleting files from new pg_clog                             ok
   Copying old pg_clog to new server                           ok
   Setting next transaction ID for new cluster                 ok
   Deleting files from new pg_multixact/offsets                ok
   Copying old pg_multixact/offsets to new server              ok
   Deleting files from new pg_multixact/members                ok
   Copying old pg_multixact/members to new server              ok
   Setting next multixact ID and offset for new cluster        sh:
   /home/kevin/pg/master/contrib/pg_upgrade/tmp_check/install//home/
   kevin/pg/master/Debug/bin: Permission denied
   *failure*
   
   Consult the last few lines of ""%s/pg_resetxlog" -O %u -m %u,%u "%s"
   > /dev/null" for the probable cause of the failure.
   Failure, exiting
   make[2]: *** [check] Error 1
   make[2]: Leaving directory `/home/kevin/pg/master/contrib/pg_upgrade'
   make[1]: *** [check-pg_upgrade-recurse] Error 2
   make[1]: Leaving directory `/home/kevin/pg/master/contrib'
   make: *** [check-world-contrib-recurse] Error 2
    
   I'm marking it as "Waiting for Author" since this seems like a "must
   fix", but I'll keep looking at it,
    
   -Kevin
   
   
   

2. Re: foreign key locks

   Alvaro Herrera <alvherre@commandprompt.com> — 2012-06-25T03:24:47Z

   Excerpts from Kevin Grittner's message of sáb jun 23 18:38:10 -0400 2012:
   > Alvaro Herrera  wrote:
   >  
   > > So here's the rebased version.
   >  
   > I found a couple problems on `make check-world`.  Attached is a patch
   > to fix one of them.  The other is on pg_upgrade, pasted below.
   
   Ah, I mismerged pg_upgrade.  The fix is trivial, AFAICS -- a function
   call is missing a log file name to be specified.  Strange that the
   compiler didn't warn me of a broken printf format specifier.  However,
   pg_upgrade itself has been broken by an unrelated commit and that fix is
   not so trivial, so I'm stuck waiting for that to be fixed.  (We really
   need automated pg_upgrade testing.)
   
   Thanks for the patch for the other problem, I'll push it out.
   
   > I'm marking it as "Waiting for Author" since this seems like a "must
   > fix", but I'll keep looking at it,
   
   Great, thanks.
   
   -- 
   Álvaro Herrera <alvherre@commandprompt.com>
   The PostgreSQL Company - Command Prompt, Inc.
   PostgreSQL Replication, Consulting, Custom Development, 24x7 support
   
   

3. Re: foreign key locks

   Alvaro Herrera <alvherre@commandprompt.com> — 2012-06-25T03:47:19Z

   Excerpts from Alvaro Herrera's message of dom jun 24 23:24:47 -0400 2012:
   > Excerpts from Kevin Grittner's message of sáb jun 23 18:38:10 -0400 2012:
   > > Alvaro Herrera  wrote:
   > >  
   > > > So here's the rebased version.
   > >  
   > > I found a couple problems on `make check-world`.  Attached is a patch
   > > to fix one of them.  The other is on pg_upgrade, pasted below.
   > 
   > Ah, I mismerged pg_upgrade.  The fix is trivial, AFAICS -- a function
   > call is missing a log file name to be specified.  Strange that the
   > compiler didn't warn me of a broken printf format specifier.  However,
   > pg_upgrade itself has been broken by an unrelated commit and that fix is
   > not so trivial, so I'm stuck waiting for that to be fixed.  (We really
   > need automated pg_upgrade testing.)
   
   Well, I ended up pushing the pg_upgrade fix anyway even though I
   couldn't test it, because I had already committed it to my tree before
   your patch.  If it still doesn't work after the other guys fix the
   outstanding problem I'll just push a new patch.
   
   In the meantime, here's fklocks v14, which also merges to new master as
   there were several other conflicts.  It passes make installcheck-world
   now.
   
   -- 
   Álvaro Herrera <alvherre@commandprompt.com>
   The PostgreSQL Company - Command Prompt, Inc.
   PostgreSQL Replication, Consulting, Custom Development, 24x7 support