Horton

Re: fix crash with Python 3.11

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, exclusion@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2022-06-23T22:54:43Z
Lists: pgsql-hackers 
Markus Wanner <markus.wanner@enterprisedb.com> writes:
> On 6/23/22 15:34, Tom Lane wrote:
>> Under what circumstances would it be OK for outside code to call
>> SPICleanup?

> For the same reasons previous Postgres versions called SPICleanup: from 
> a sigsetjmp handler that duplicates most of what Postgres does in such a 
> situation.

Does such code exist?  I don't see any other calls in Debian code search,
and I find it hard to believe that anyone would think such a thing is
maintainable.

			regards, tom lane

Commits

  1. Re-add SPICleanup for ABI compatibility in stable branch

  2. Fix SPI's handling of errors during transaction commit.

  3. Don't use static storage for SaveTransactionCharacteristics().